Fix CodeQL scanning issues

ISSUE: ADPM-70
Adyen · Oct 8, 2024 · 497fbf0 · 497fbf0
1 parent 63ee734
commit 497fbf0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/Resources/views/backend/_resources/js/ElementGenerator.js b/Resources/views/backend/_resources/js/ElementGenerator.js
@@ -195,7 +195,7 @@ if (!window.AdyenFE) {
 
         const handleOnOptionChange = (listItem, storeId) => {
             hiddenInput.value = storeId;
-            updateTextOnChange && (switchButton.firstElementChild.innerHTML = listItem.innerText);
+            updateTextOnChange && (switchButton.firstElementChild.textContent = listItem.innerText);
             list.classList.remove('adls--show');
 
             listItems.forEach((li) => li.classList.remove('adls--selected'));

diff --git a/Resources/views/backend/_resources/js/PageControllerFactory.js b/Resources/views/backend/_resources/js/PageControllerFactory.js
@@ -20,7 +20,11 @@ if (!window.AdyenFE) {
 
             name += 'Controller';
 
-            return AdyenFE[name] ? new AdyenFE[name](configuration) : null;
+            if(!(AdyenFE.hasOwnProperty(name) && typeof AdyenFE[name] === 'function')) {
+                return null;
+            }
+
+            return new AdyenFE[name](configuration);
         };
     }