Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate iOS to v5 #326

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Migrate iOS to v5 #326

merged 6 commits into from
Dec 13, 2023

Conversation

descorp
Copy link
Contributor

@descorp descorp commented Dec 8, 2023

Open PR

Changes

  • migrate to v5
  • rename XxxComponent into XxxModule

goergisn
goergisn previously approved these changes Dec 11, 2023
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

13.2% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@descorp descorp merged commit ac33a1a into develop Dec 13, 2023
7 of 8 checks passed
@descorp descorp deleted the ios_v5 branch December 13, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goergisn goergisn goergisn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@descorp @goergisn