Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V5 android advanced #320

Merged
merged 18 commits into from
Dec 7, 2023
Merged

V5 android advanced #320

merged 18 commits into from
Dec 7, 2023

Conversation

descorp
Copy link
Contributor

@descorp descorp commented Dec 5, 2023 •
edited
Loading

Open PR

Changes

  • adopt Android v5
  • move <service android:name="com.adyenreactnativesdk.component.dropin.AdyenCheckoutService" android:exported="false" /> into SDK manifest

Other

  • cleanup packages
  • cleanup JS code
  • cleanup Android code

@descorp descorp force-pushed the v5_android_advanced branch from dae6c7b to 19b115c Compare December 6, 2023 16:00
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@descorp descorp marked this pull request as ready for review December 7, 2023 11:43
@descorp descorp merged commit f581d32 into develop Dec 7, 2023
8 of 9 checks passed
@descorp descorp deleted the v5_android_advanced branch December 7, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robert-SD Robert-SD Robert-SD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@descorp @Robert-SD