Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9480] Setting cc_type value for Carte Bancaire #2847

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[ECP-9480] Setting cc_type value for Carte Bancaire #2847

wants to merge 4 commits into from

Conversation

khushboo-singhvi
Copy link
Contributor

Description
When using a Cartes Bancaire card to complete the payments, the cc_type in the sales_order_payment table is null. This is the case for a normal non co branded CB card and with co-branded when selecting CB. Other card payments add cc_type correctly.
This PR aims to add the correct cc_type to the database table if it is null or not set already.

Tested scenarios

  • Tested the correct value for non co branded CB card and with co-branded when selecting CB, and other redirect payment methods.

Fixes

@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner January 9, 2025 10:21
@khushboo-singhvi khushboo-singhvi changed the title Setting cc_type value for Carte Bancaire [ECP-8779] Setting cc_type value for Carte Bancaire Jan 9, 2025
@khushboo-singhvi khushboo-singhvi changed the title [ECP-8779] Setting cc_type value for Carte Bancaire [ECP-9480] Setting cc_type value for Carte Bancaire Jan 9, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candemiralp candemiralp Awaiting requested review from candemiralp

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khushboo-singhvi @candemiralp