[ECP-9230] Prevent refreshing Quote ID during page refresh on product page for express payment #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 12, 2024 11:35
…nse before the call to setExpressMethods is made
…same page even after refresh, destroy the quote id if travel to another page
SushmitaThakur
changed the title
RokPopov
previously approved these changes
Jul 15, 2024
candemiralp
reviewed
Jul 15, 2024
|
candemiralp
approved these changes
Jul 17, 2024
RokPopov
approved these changes
Jul 17, 2024
Merged
raoulritter
pushed a commit
that referenced
this pull request
Aug 15, 2024
* [ECP-8715] Refactor initPayments JS action * Revert "[ECP-9230] Prevent refreshing Quote ID during page refresh on product page for express payment (#93)" This reverts commit 4deb8c4. * Improve error handling on shipping details changes * Revert ECP-9230 * Fix PDP payment issues and update endpoints * Fix tax calculation issue on PayPal express * Use billing address if the quote is virtual * Fix /paymentMethods request amount value --------- Co-authored-by: Can Demiralp <[email protected]>
khushboo-singhvi
added a commit
that referenced
this pull request
Aug 21, 2024
* [ECP-9072] Implement backend requirements of PayPal express (#84) * [ECP-9072] Add new configuration values * [ECP-9072] Refactor Button classes and create a new one for PayPal * [ECP-9072] Implement an abstract config getter for showOn fields * [ECP-9072] Define payment method variants * [ECP-9072] Implement abstract observer and simplify the observer logic * [ECP-9072] Add new event for PayPal observer * [ECP-9072] Add new resolver for PayPal * [ECP-9072] Rename the variable * [ECP-9072] Create forced required frontend template file * [ECP-8992] Remove setup_version constraint from the data patch * [ECP-8992] Update configuration paths to reflect real Adyen tx_variants * [ECP-8992] Implement abstract template for shortcut buttons * [ECP-8992] Update abstract observer * [ECP-8992] Create Magento frontend JS component for PayPal express * [ECP-8992] Update frontend template * [ECP-8992] Refactor code duplication * [ECP-8992] Create abstract config route patcher --------- Co-authored-by: Can Demiralp <[email protected]> * [ECP-9114] Implement /payments endpoint for express use cases (#88) Co-authored-by: Can Demiralp <[email protected]> * [ECP-9082] Implement Checkout API's /paypal/updateOrder endpoint (#86) * Implement Checkout API's /paypal/updateOrder endpoint * [ECP-9082] Obtain order related information from backend and implement guest endpoint --------- Co-authored-by: Can Demiralp <[email protected]> Co-authored-by: Can Demiralp <[email protected]> * [ECP-9072] Implement backend requirements of PayPal express (#84) * [ECP-9072] Add new configuration values * [ECP-9072] Refactor Button classes and create a new one for PayPal * [ECP-9072] Implement an abstract config getter for showOn fields * [ECP-9072] Define payment method variants * [ECP-9072] Implement abstract observer and simplify the observer logic * [ECP-9072] Add new event for PayPal observer * [ECP-9072] Add new resolver for PayPal * [ECP-9072] Rename the variable * [ECP-9072] Create forced required frontend template file * [ECP-8992] Remove setup_version constraint from the data patch * [ECP-8992] Update configuration paths to reflect real Adyen tx_variants * [ECP-8992] Implement abstract template for shortcut buttons * [ECP-8992] Update abstract observer * [ECP-8992] Create Magento frontend JS component for PayPal express * [ECP-8992] Update frontend template * [ECP-8992] Refactor code duplication * [ECP-8992] Create abstract config route patcher --------- Co-authored-by: Can Demiralp <[email protected]> * [ECP-9114] Implement /payments endpoint for express use cases (#88) Co-authored-by: Can Demiralp <[email protected]> * [ECP-9082] Implement Checkout API's /paypal/updateOrder endpoint (#86) * Implement Checkout API's /paypal/updateOrder endpoint * [ECP-9082] Obtain order related information from backend and implement guest endpoint --------- Co-authored-by: Can Demiralp <[email protected]> Co-authored-by: Can Demiralp <[email protected]> * [ECP-9143] Configure the place for the express components (PDP, minicart, summary), (#91) * [ECP-9143] Configure the place for the express components (PDP, minicart, summary), * [ECP-9143] Adding braces for if else block * Update Observer/AddGooglePayShortcuts.php Removing unwanted , Co-authored-by: Rok Popov Ledinski <[email protected]> * [ECP-8400] Support virtual products on express payments (#78) * [ECP-8400] Implement virtualQuoteModel to obtain quote type * [ECP-8400] Fix pdp virtual quote condition * [ECP-8400] Fix placing order with virtual product * [ECP-8400] Handle payment status * [ECP-8400] Support virtual products on Apple Pay express * [ECP-8400] Update the related callbacks * [ECP-8400] Fix virtualQuote model * [ECP-8400] Fix virtualQuote model * [ECP-8400] Fix virtualQuote model --------- Co-authored-by: Can Demiralp <[email protected]> * Add onAvailable event for Apple Pay (#82) Co-authored-by: Dimitri BOUTEILLE <[email protected]> Co-authored-by: Can Demiralp <[email protected]> * Version bump 2.1.0 * [ECP-9143] Configure the place for the express components (PDP, minicart, summary), # Conflicts: # Observer/AddApplePayShortcuts.php # Observer/AddGooglePayShortcuts.php * Solving sonarcloud pipeline --------- Co-authored-by: Rok Popov Ledinski <[email protected]> Co-authored-by: Can Demiralp <[email protected]> Co-authored-by: Can Demiralp <[email protected]> Co-authored-by: Dimitri BOUTEILLE <[email protected]> Co-authored-by: Dimitri BOUTEILLE <[email protected]> Co-authored-by: RokPopov <[email protected]> * [ECP-9079] Implementing frontend logic for Paypal Express (#95) * [ECP-9079] Adding frontend component to Paypal * [ECP-9079] Adding frontend component to Paypal * [ECP-9079] Adding frontend component to Paypal * [ECP-9079] Adding frontend component to Paypal * [ECP-9079] Adding frontend component to Paypal * [ECP-9079] Adding frontend component to Paypal - adding new Observer to change the payment method name back to paypal and set status as New. * Abstracting the code, removing the console.logs * Adding payment-details call block for express and not using module-payment one, bcoz it incorrectly checks the loggedIn User logic * Removing isMultishipping parameter, as this is not a valid use case for Express * Removing duplicates * Removing useless comments Co-authored-by: Ángel Campos <[email protected]> * Resolving comments on PR by not passing amount from frontend rather getting the subtotal from the quote for the /payments call and also removing unwanted comments and getting the order status dynamically from the state * Updating naming conventions to prevent confusions for future. * Updating assignments within the condition check * Found the refence here https://docs.adyen.com/development-resources/client-side-authentication/migrate-from-origin-key-to-client-key/ * Update button.js Removing unwanted console.log * Update AdyenInitPayments.php Getting the currency also from the Quote instead of chargedQuoteCurrency --------- Co-authored-by: Ángel Campos <[email protected]> * Enabling Paypal Express on PDP (#102) Solving some of the obvious sonarcloud suggestions * Providing telemetry's endpoint expressPage field to payment method component configurations (#103) * Refactoring the code and removing deprecated facades * Updating changes for PDP for logged in user * [ECP-9381] Fix PDP payment, discounted price and tax calculation (#104) * [ECP-8715] Refactor initPayments JS action * Revert "[ECP-9230] Prevent refreshing Quote ID during page refresh on product page for express payment (#93)" This reverts commit 4deb8c4. * Improve error handling on shipping details changes * Revert ECP-9230 * Fix PDP payment issues and update endpoints * Fix tax calculation issue on PayPal express * Use billing address if the quote is virtual * Fix /paymentMethods request amount value --------- Co-authored-by: Can Demiralp <[email protected]> * Adding missing semicolons * Removing unused versions * Beautifying the code --------- Co-authored-by: Can Demiralp <[email protected]> Co-authored-by: Can Demiralp <[email protected]> Co-authored-by: raoulritter <[email protected]> Co-authored-by: khushboos <[email protected]> Co-authored-by: Dimitri BOUTEILLE <[email protected]> Co-authored-by: Dimitri BOUTEILLE <[email protected]> Co-authored-by: Ángel Campos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On product page for express checkouts, the quote-id is being created every time the page is refreshed on the browser and as a result a multiple entries exist in the
quotetable for the same product. This happens for both logged in or guest user where quote id is maintained for the session but not through refresh. This PR includes storing the quote-id to JS local storage variable and accessing it whenevergetRequestmethod is called, to check whether there is an existing quote-id, if not then letgetRequestcreate a new one.Tested scenarios
Fixed issue: