[ECP-9485]PayPal Express - Two PayPal Tokenization Options #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
shanikantsingh
approved these changes
Feb 3, 2025
candemiralp
approved these changes
Feb 4, 2025
amihajlovski
approved these changes
Feb 4, 2025
Merged
khushboo-singhvi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the implementation of PayPal Express, when the Express module is enabled there are two PayPal tokenization options available in the admin tokenization settings in Magento.
When express is disabled, there is only one. Ideally they should both fall under one and seems to be because PayPal Express is implemented as a separate payment method.
This PR aims at having single Paypal Tokenization option for Main module and Express checkout.
Tested scenarios
Fixed issue: