fix: cap input quantity, truncate rfq card qty #2344
Conversation
|
(auto-deploy) A deployment has been created for this Pull Request Preview linksAs part of the code review process, please ensure that you test against the following
PerformancePlease ensure that this PR does not degrade the performance of the UI. We should maintain a performance score of 95+. |
| @@ -72,7 +76,7 @@ const quantity$ = prepareStream$(_quantity$, "").pipe( | |||
| const numValue = Math.trunc(Math.abs(parseQuantity(quantity))) | |||
There was a problem hiding this comment.
suggestion(/later): I would put this whole thing in the util function, or create a new one, and could perhaps simplify If parseQuantity() returns NaN, which it can, then we really catch it as early as possible.
Also, a near dup of code in formatNotional, but that has no Math.trunc() ..
| @@ -216,8 +217,10 @@ export const [usePrice, price$] = bind( | |||
|
|
|||
| const truncated = formatter(inputQuantityAsNumber) | |||
|
|
|||
| const value = Number( | |||
| truncated.replace(filterRegExp, "").replace(decimalRegExp, "."), | |||
| const value = applyMaximum( | |||
There was a problem hiding this comment.
suggestion re above: some could be extracted to util module (e.g. decimalRegExp is a dup)
| @@ -230,3 +230,8 @@ export const parseQuantity = (rawValue: string): number => | |||
| Number(rawValue.replace(filterRegExp, "").replace(decimalRegExp, ".")) | |||
|
|
|||
| export const adjustUserCreditQuantity = (value: number): number => value * 1000 | |||
|
|
|||
| const MAX_INPUT_VALUE = 100000000 | |||
There was a problem hiding this comment.
minor: 100 mill, but hard to read, I always use underscores ..
No description provided.