Rrsbmk/master #20
Open
Rrsbmk/master #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into rrsbmk/master
… into rrsbmk/master
… into rrsbmk/master
… into rrsbmk/master
… into rrsbmk/master
…o specify a market
… into rrsbmk/master
… into rrsbmk/master
| color: #000000; | ||
| } | ||
|
|
||
| .larger_nav_button { |
There was a problem hiding this comment.
Watch your naming convention with the _ rather than the - here and on all styles below
|
@brittanykohler @rileyrileyrose Nice job on this! I like the way you've use the order variable to do some fancy sorting. There is some violation of the single responsibility principle - primarily from the views. Watch out for conditionals that are doing extra work - be mindful of mutually exclusive conditions and ensure they are using if/else/elsifs. Your final site is so beautious! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://extraordinary-farmers-market.herokuapp.com/