Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Optimize simple string getters #493

Merged
merged 2 commits into from
Dec 8, 2024
Merged

refactor!: Optimize simple string getters #493

merged 2 commits into from
Dec 8, 2024

Conversation

mwcampbell
Copy link
Contributor

I can't think of any reason why role_description and placeholder on accesskit_consumer::Node need to return an Option<String> rather than an Option<&str>. It just wastes an allocation, at least on Windows and macOS.

@DataTriny DataTriny merged commit 484fd7c into main Dec 8, 2024
9 checks passed
@DataTriny DataTriny deleted the optimize-string-getters branch December 8, 2024 21:36
@github-actions github-actions bot mentioned this pull request Dec 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DataTriny DataTriny DataTriny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwcampbell @DataTriny