refactor!: Rename NodeBuilder to Node and the old Node to FrozenNode
#476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataTriny
reviewed
Oct 29, 2024
common/src/lib.rs
Outdated
| option_properties_debug_method! { debug_option_properties, [transform, bounds, text_selection,] } | ||
| } | ||
|
|
||
| vec_property_methods! { | ||
| (CustomActions, CustomAction, custom_actions, get_custom_action_vec, set_custom_actions, set_custom_action_vec, push_custom_action, push_to_custom_action_vec, clear_custom_actions) | ||
| } | ||
|
|
||
| impl fmt::Debug for Node { | ||
| impl fmt::Debug for FrozenNode { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| let mut fmt = f.debug_struct("Node"); |
There was a problem hiding this comment.
Did you not change the name of the struct on purpose? I think we still want the debug representation to show if it's a frozen node or not, right?
DataTriny
approved these changes
Oct 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing this, passing the new
Node(formerNodeBuilder) inTreeUpdate, and having the consumer convert to the slightly smallerFrozenNode, we make the API more convenient for all users while not giving up the node size optimization. And it's probably slightly better for binary size to do the conversion toFrozenNodein just one place.