improve subscription #122
Merged
improve subscription #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
approved these changes
Oct 31, 2023
ermalkaleci
added a commit
that referenced
this pull request
Nov 1, 2023
…nnecessary but I was wrong. Subscription request needs to complete with Ok(()) while background task will keep sending updates.
ermalkaleci
added a commit
that referenced
this pull request
Nov 1, 2023
…nnecessary but I was wrong. Subscription request needs to complete with Ok(()) while background task will keep sending updates. (#123)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure to close subscription when sink is closed also there's no need to spawn another task inside merge_subscription middleware