-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scripts, make examples
bin
's
#74
Fix scripts, make examples
bin
's
#74
Conversation
Why did we change the dir name ( |
Just so package name matches to the directory name. And this section doesn't include renaming of the Would you prefer to get it reverted? |
echo "Please create metadata.json for module metadata"; exit; \ | ||
fi | ||
|
||
tmp_dir="$(mktemp -d)" | ||
schema_out_dir="$tmp_dir/{{namespace}}/{{name}}/{{version}}" | ||
metadata_out_dir="$tmp_dir/{{namespace}}/{{name}}" | ||
schema_out_dir="$tmp_dir/{{namespace}}/{{name}}/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This schema out dir includes the namespace while the schema.sh script doesn't seem to do that. Is that the expected behaviour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we need to include namespace in "app_template/schemas"? But we totally should include them when we push to the "AbstractSdk/schemas"
Oh and can we get rid of |
Yeah we can remove it, we only use it in one place! What do you mean it's huge? Just tested compiled wasms with:
and without:
Could be nice to have abstract-based macro that generates those 3 consts - module-name, module-namespace and module-id and verify it in compile time. |
Yes, would love a custom macro for this that expands in all three variables.
Looked at the crate size and was very big. Guess compiler does a great job here at optimizing. |
Don't think there's much to optimize! We only use one macro from the crate, so only it's result ends up in the binary(formatted |
This PR fixes outstanding tasks on template
examples
tobin