-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit Fixes 1: XION Authentication fix and test #546
Conversation
Deploying abstract-docs with
|
Latest commit: |
53a1373
|
Status: | ✅ Deploy successful! |
Preview URL: | https://1d3cd94d.abstract-docs.pages.dev |
Branch Preview URL: | https://fix-auth-permissions-xio.abstract-docs.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
framework/packages/abstract-std/src/objects/ownership/gov_ownable.rs
Outdated
Show resolved
Hide resolved
if let Ok(true) = AUTH_ADMIN.query(querier, address) { | ||
return Ok(()); | ||
} else { | ||
return Err(crate::objects::ownership::GovOwnershipError::NotOwner); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we return a more specific error such as NotAdmin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really because this logic ensures that it's the owner calling the contract. If a module calls the account, then it's not the owner calling it. So I would stick with that
…ble.rs Co-authored-by: Interchain Adair <[email protected]>
…tract into fix/auth-permissions-xio
This Pr aims at adding Auth permissions fix for xion (found during the audit by us)
Changes :
Checklist