-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOGIN #3 and #4 (KN-44 KN-70) Login Refactor #164
LOGIN #3 and #4 (KN-44 KN-70) Login Refactor #164
Conversation
Signed-off-by: abigaildawson <[email protected]>
… bio photos that are no longer being used Signed-off-by: abigaildawson <[email protected]>
Add JP to Core Contributors, update Past Core Contributors and remove…
Signed-off-by: abigaildawson <[email protected]>
Signed-off-by: abigaildawson <[email protected]>
Signed-off-by: abigaildawson <[email protected]>
Signed-off-by: abigaildawson <[email protected]>
Signed-off-by: abigaildawson <[email protected]>
…ization JWT Authorization Tasks Complete
Signed-off-by: abigaildawson <[email protected]>
Add SASS to dev dependencies
Add Conditional Rendering for Password Validation Messages.
…ince those are more up-to-date
… in loginModal file
… desktop and mobile
Looks like there's a lot of commits, but this includes code updated from develop and main that's not yet on this user-auth branch. Let me know if you'd like to discuss or would like for me to do something different |
Sorry! I’ll get to this soon! Been busy lately with life happenings! |
No worries all good! 🙌 |
Signed-off-by: abigaildawson <[email protected]>
Signed-off-by: abigaildawson <[email protected]>
Signed-off-by: abigaildawson <[email protected]>
Signed-off-by: abigaildawson <[email protected]>
refactored DemoStudyText and DemoTranslateText from css to scss files
…exg/KN-44-login-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Alex! This looks amazing! (and luckily no merge conflicts). I love the flow! If possible, can you or JP make sure that the sign-up form is also a pop up, just like the login form is?
Yes, JP and I will look into this! |
@psantos2107 Just spoke with JP, and mentioned it would be easier to merge these login changes with user-auth first, and then he can work on the rest of the signup code tasks on a new branch. This PR is mainly for the login flow anyway, but does have some signup related code due to the reusable components between the two. Would it be okay to merge as is? |
yeah! That’s not a problem at all! I’ll merge it right now |
Okay! It’s merged! 😊 |
🙌 Awesome, thank you! |
The Signup modal is done! I’ve sent a pull request to |
Thanks JP! I’ll check it out later today |
This includes the login modal and refactored login page (if user tries to access dashboard but is not logged in) according to the figma wireframes. I used @JPEscobari's FormInput component and worked with him to make it reusable between both signup and login. The login modal uses this component as well, and uses the reusable modal in ui-components/Modal.
Notes:
Some of @JPEscobari 's work with the signup is in this PR as well. Mainly updating the password validation. He will submit a PR for the rest of signup changes after this is merged with this user-auth branch!