Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the pan issue #13

Open
wants to merge 1 commit into
base: with_navbar
Choose a base branch
from

Conversation

priyansh-narang2308
Copy link

@priyansh-narang2308 priyansh-narang2308 commented Dec 23, 2024

Resolve #9
File Updated: zoomscript.js , courousel.js
Added Mouse Panning: Implemented mousedown, mousemove, and mouseup event handlers for smooth drag, panning with displacement limits.
Improved pinch-zoom functionality
Added getStyleInt and setStyleInt for consistent position updates.
Ensured seamless navigation for both mouse and touch inputs with scaling and panning constraints.

image
Added this before the touchstart function.
In the corousel.js added the map container which lists the mouseup,down and leave functionalty
image
Added just after the touchend listener

@Ashrockzzz2003 Ashrockzzz2003 added the AMWOC Part of ACM Amrita WOC S01 Contest. label Dec 25, 2024
@priyansh-narang2308
Copy link
Author

@Ashrockzzz2003 Can the PR be looked upon plss as i have to contribute to other projects as well
So if this is not approved i cant go to next project🫡🫡

@Ashrockzzz2003
Copy link
Collaborator

Ashrockzzz2003 commented Dec 27, 2024

@Ashrockzzz2003 Can the PR be looked upon plss as i have to contribute to other projects as well So if this is not approved i cant go to next project🫡🫡

We've reviewed #12 which is also by you. You've not responded yet. After that one, we'll do this one : )

Will review by this week. You can work on other projects too. After we review this, check this one. Patience is key in this WOC @priyansh-narang2308.

@priyansh-narang2308
Copy link
Author

Ok So I have to make changes on the previous one right
Will do it 👍🏻

@priyansh-narang2308
Copy link
Author

Hey @Ashrockzzz2003 I have made changes to the previous one
You can review it 😊🫡

@Ashrockzzz2003
Copy link
Collaborator

/bounty 25 @priyansh-narang2308

@Abhinav-ark
Copy link
Owner

@priyansh-narang2308 I noticed that the compass moves along with the map while panning sometimes.

Screen.Recording.2025-03-02.000930.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMWOC Part of ACM Amrita WOC S01 Contest. AMWOC-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Pan.
3 participants