Skip to content

Commit

Permalink
Fixed inefficiencies in building the SSL bundle - in particular the c…
Browse files Browse the repository at this point in the history
…onstant rerunning of config.status

git-svn-id: svn+ssh://svn.gna.org/svn/gnustep/libs/base/trunk@30181 72102866-910b-0410-8b05-ffd578937521
  • Loading branch information
nicola committed Apr 18, 2010
1 parent e9fd9c5 commit a73ccdc
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 18 deletions.
7 changes: 7 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
2010-04-18 Nicola Pero <[email protected]>

Fixed inefficiencies in building the SSL bundle.
* SSL/Makefile.postable: Do not create GNUSTEP_TARGET_DIR/config.h
from config.h; do not depend on config.status.
* SSL/Makefile.preamble: Corresponding updates to includes.

2010-04-18 Nicola Pero <[email protected]>

Fixed bug 25356 ("make ignoring installation domain configuration
Expand Down
33 changes: 16 additions & 17 deletions SSL/Makefile.postamble
Original file line number Diff line number Diff line change
Expand Up @@ -67,29 +67,28 @@

# Things to do after distcleaning
after-distclean::
rm -rf $(GNUSTEP_TARGET_DIR)/config.h config.status config.log config.cache TAGS config.mak config.h
rm -rf config.status config.log config.cache TAGS config.mak config.h

# Things to do before checking
# before-check::

# Things to do after checking
# after-check::

config.mak: config.mak.in config.status
./config.status
-touch config.mak
config.mak: config.mak.in
./configure

#
# The config.h file is specific to a target
#
$(GNUSTEP_TARGET_DIR)/config.h: config.status
./config.status
-touch config.h
ifneq ($(GNUSTEP_TARGET_DIR), .)
$(MKDIRS) $(GNUSTEP_TARGET_DIR)
-mv config.h $(GNUSTEP_TARGET_DIR)
endif

# Run configure manually if you need to pass any options
config.status:
config.h: config.h.in
./configure

# PS: the config.h file is specific to the target that was configured.
# At the moment, we use a single config.h file in ./, so if you want
# to change target, you have to reconfigure the SSL bundle, which
# would remove the configuration for the previous target and create a
# configuration for the new target.
#
# A possible improvement would be to have configure store each
# config.h file in a target-specific directory so that when you
# reconfigure for a different target, you don't lose the configuration
# for the previous target. It doesn't seem to help much though as you
# still have to configure and build multiple times.
2 changes: 1 addition & 1 deletion SSL/Makefile.preamble
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ ADDITIONAL_CFLAGS =
# include config.h from gnustep-base instead of the
# one in this directory. It is required to find
# GSPrivate.h on non-flattened though.
ADDITIONAL_INCLUDE_DIRS = -I./$(GNUSTEP_TARGET_DIR) \
ADDITIONAL_INCLUDE_DIRS = -I. \
-I../Source/$(GNUSTEP_TARGET_DIR) -I../Source \
-I../Headers/Additions -I../Headers

Expand Down

0 comments on commit a73ccdc

Please sign in to comment.