Fix type loader when type check output overflows the buffer #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the parlour CLI and you have a large amount of sorbet typecheck errors,
the parlour process will hang.
Parlour::TypeLoader
usesOpen3.capture3
which comes with this warning-- https://ruby-doc.org/3.4.1/stdlibs/open3/Open3.html#method-c-popen3
The code that calls
Open3.capture3
only reads from stdout. So instead of implementing a fix for this, I switched to usingOpen3.capture2
. Which returns stdout as a string and aProcess::Status
object.This change should not affect the functionality of the CLI.