Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate fallback and aggregator output is compatible #573

Merged
merged 7 commits into from
May 23, 2024

Conversation

HLasse
Copy link
Collaborator

@HLasse HLasse commented May 23, 2024

Fixes #569

@HLasse HLasse requested a review from MartinBernstorff May 23, 2024 07:42
Copy link

codspeed-hq bot commented May 23, 2024

CodSpeed Performance Report

Merging #573 will not alter performance

Comparing validate-fallback-and-value-can-recast (e327665) with main (7845fb9)

Summary

✅ 7 untouched benchmarks

@MartinBernstorff MartinBernstorff changed the title Validate fallback and aggregator output is compatible feat: validate fallback and aggregator output is compatible May 23, 2024
Copy link
Collaborator

@MartinBernstorff MartinBernstorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@HLasse HLasse enabled auto-merge May 23, 2024 10:52
@HLasse HLasse merged commit 773e269 into main May 23, 2024
10 of 11 checks passed
@HLasse HLasse deleted the validate-fallback-and-value-can-recast branch May 23, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HasValuesAggregator fails if fallback type does not match bool
2 participants