Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#514): simplify public-facing types by inlining type-aliases #564

Merged

Conversation

HLasse
Copy link
Collaborator

@HLasse HLasse commented May 3, 2024

fix(#514): simplify public-facing types by inlining type-aliases

Fixes #514

refactor: inline LookDistance and LookDistances

refactor: inline ValueType

refactor: inline default entity_id_col_name

refactor: inline default_prediction_time_uuid_col_name

refactor: inline default_pred_time_col_name

refactor: inline default_timestamp_col_name

refactor: inline InitDF_T

lint

Copy link
Collaborator Author

HLasse commented May 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HLasse and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented May 3, 2024

CodSpeed Performance Report

Merging #564 will not alter performance

Comparing fix/514/simplify_public-facing_types_by_inlining_type-aliases (22c3ce6) with fix/514/simplify_public-facing_types_by_inlining_type-aliases (cdebaa7)

Summary

✅ 7 untouched benchmarks

Copy link
Contributor

github-actions bot commented May 7, 2024

This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 7, 2024
@HLasse HLasse requested a review from MartinBernstorff May 7, 2024 13:16
@HLasse HLasse removed the Stale label May 7, 2024
Copy link
Contributor

This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 10, 2024
@HLasse HLasse removed the Stale label May 10, 2024
Copy link
Collaborator

@MartinBernstorff MartinBernstorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let the judgement be up to you 👍

Copy link
Contributor

This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 15, 2024
Copy link
Collaborator

@HLasse Ready to make a decision here? 😉

@HLasse
Copy link
Collaborator Author

HLasse commented May 17, 2024

On the list for today 👍

@github-actions github-actions bot removed the Stale label May 17, 2024
Copy link
Contributor

This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 21, 2024
@HLasse HLasse enabled auto-merge May 22, 2024 07:26
@HLasse HLasse merged commit 0106a84 into main May 22, 2024
12 checks passed
@HLasse HLasse deleted the fix/514/simplify_public-facing_types_by_inlining_type-aliases branch May 22, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: simplify public-facing types by inlining type-aliases
2 participants