Assertion, Logging and Exception #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 14, 2024 13:59
Comment on lines
+56
to
+58
| } catch (Exception e) { | ||
| logger.log(Level.WARNING, "Error processing deletion"); | ||
| System.out.println("Error in deleting files, specific error: " + e.getMessage()); |
There was a problem hiding this comment.
Good use of catch statement to catch an exception processing the delete command and print out the specific error message
Comment on lines
+176
to
+178
| assert nric != null: | ||
| "Please provide a valid NRIC"; | ||
|
|
There was a problem hiding this comment.
Good use of assertion to assert nric != null when user wants to delete a specific patient record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Assertion, Logging and Exception.
Modify the delete function.
Add JUnit test for multiple outputs