Merge pull request #205 from seewhyjay/tests

Feat: Add more tests to increase coverage

src/main/java/seedu/address/logic/commands/assignment/ListAssignmentCommand.java

@@ -7,6 +7,7 @@
 
 import java.util.function.Predicate;
 
+import seedu.address.commons.util.ToStringBuilder;
 import seedu.address.logic.Messages;
 import seedu.address.logic.commands.CommandResult;
 import seedu.address.model.Model;
@@ -64,6 +65,8 @@ public boolean equals(Object other) {
 
     @Override
     public String toString() {
-        return this.predicate.toString();
+        return new ToStringBuilder(this)
+                .add("predicate", predicate)
+                .toString();
     }
 }

src/test/java/seedu/address/logic/commands/assignment/ListAssignmentCommandTest.java

@@ -1,6 +1,8 @@
 package seedu.address.logic.commands.assignment;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static seedu.address.logic.commands.CommandAssignmentTestUtil.assertCommandSuccess;
 import static seedu.address.testutil.TypicalAssignments.getTypicalAddressBook;
 
@@ -55,4 +57,29 @@ public void execute_listIsFiltered_showsFilteredList() {
                 commandResult.getFeedbackToUser()
         );
     }
+
+    @Test
+    public void equals() {
+        String[] dates = new String[] {"2023-11-31 18:45", "2024-11-31 18:45"};
+        List<String> datesAsList = Arrays.asList(dates);
+        ListAssignmentCommand listFirstCommand = new ListAssignmentCommand();
+        ListAssignmentCommand listSecondCommand =
+                new ListAssignmentCommand(new AssignmentBetweenStartandEndPredicate(datesAsList));
+
+        // same object -> returns true
+        assertTrue(listFirstCommand.equals(listFirstCommand));
+
+        // same values -> returns true
+        ListAssignmentCommand listFirstCommandCopy = new ListAssignmentCommand();
+        assertTrue(listFirstCommand.equals(listFirstCommandCopy));
+
+        // different types -> returns false
+        assertFalse(listFirstCommand.equals(1));
+
+        // null -> returns false
+        assertFalse(listFirstCommand.equals(null));
+
+        // different person -> returns false
+        assertFalse(listFirstCommand.equals(listSecondCommand));
+    }
 }

src/test/java/seedu/address/logic/commands/internships/task/MarkInternshipTaskCommandTest.java

@@ -77,7 +77,7 @@ public void equals() {
         assertFalse(markFirstCommand.equals(1));
 
         // null -> returns false
-        assertFalse(markFirstCommand == null);
+        assertFalse(markFirstCommand.equals(null));
 
         // different person -> returns false
         assertFalse(markFirstCommand.equals(markSecondCommand));

src/test/java/seedu/address/logic/commands/internships/task/UnMarkInternshipTaskCommandTest.java

@@ -77,7 +77,7 @@ public void equals() {
         assertFalse(unMarkFirstCommand.equals(1));
 
         // null -> returns false
-        assertFalse(unMarkFirstCommand == null);
+        assertFalse(unMarkFirstCommand.equals(null));
 
         // different person -> returns false
         assertFalse(unMarkFirstCommand.equals(unMarkSecondCommand));