Fix error messages for payment class and refactored code #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
============================================
+ Coverage 78.52% 79.42% +0.90%
- Complexity 685 696 +11
============================================
Files 95 95
Lines 2095 2095
Branches 255 258 +3
============================================
+ Hits 1645 1664 +19
+ Misses 374 361 -13
+ Partials 76 70 -6
Continue to review full report at Codecov.
|
atyhamos
approved these changes
Nov 4, 2021
|
|
||
| if (zeroPaymentVal.equals(existingPaymentValue) && newPayByDate == null && existingPayByDate == null) { | ||
| boolean hasZeroPaymentValue = ZERO_PAYMENT_VAL.equals(existingPaymentValue); |
There was a problem hiding this comment.
As "0" is not equal to "0.00", perhaps a simpler implementation would be
Suggested change
| boolean hasZeroPaymentValue = ZERO_PAYMENT_VAL.equals(existingPaymentValue); | |
| boolean hasZeroPaymentValue = Double.parseDouble(existingPaymentValue) == 0; |
There was a problem hiding this comment.
Thanks! Have committed the above suggestions
| @@ -126,7 +126,7 @@ public String getOverdueStatus() { | |||
| } else if (payByDateAsString.equals("-")) { | |||
| return "No (Pay-by date not set)"; | |||
| } else { | |||
| return "No (by " + payByDateAsString + ")"; | |||
| return "No (Next payment date by: " + payByDateAsString + ")"; | |||
There was a problem hiding this comment.
I think this will clear the confusion that our testers had 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #147, #126
For #147, changed payment message from
Overdue: No (By: XXX)toOverdue: No (Next payment date by: XXX)to make it more explicit that it refers to the next upcoming payment date to be expected.For #126, adjusted according to what was suggested and changed error message to
tutee index is invalid.Added test cases for payment commands as well