Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: introduction to PPIHYD #110

Merged
merged 2 commits into from
Oct 25, 2024
Merged

ENH: introduction to PPIHYD #110

merged 2 commits into from
Oct 25, 2024

Conversation

isilber
Copy link
Contributor

@isilber isilber commented Oct 23, 2024

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Oct 25, 2024

View / edit / reply to this conversation on ReviewNB

zssherman commented on 2024-10-25T19:17:43Z
----------------------------------------------------------------

Link seems to be not working on my end.


@zssherman
Copy link
Collaborator

@isilber Looks good to me! Only one comment, the ACT link wasn't working on my end.

@zssherman zssherman self-requested a review October 25, 2024 19:18
@isilber
Copy link
Contributor Author

isilber commented Oct 25, 2024

Done @zssherman , thanks. I updated that link as well as the broken link in the SQUIRE notebook.

@zssherman
Copy link
Collaborator

Looks good to me! @mgrover1 we good to merge this in?

@mgrover1 mgrover1 merged commit 8585891 into ARM-Development:main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants