Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FWF-3749: [Feature] Application list API changes related to client UI #2533

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

auslin-aot
Copy link
Contributor

Issue Tracking

JIRA:
Issue Type: BUG/ FEATURE
https://aottech.atlassian.net/browse/FWF-3749

Changes

  • Added filter param to support formId (parentFormId) to filter the submissions for a specific form
  • Added includeDrafts=true - drafts & submissions in response
  • Added onlyDrafts=true - only drafts in response
  • By default, only submissions are returned
  • Added createdUserSubmissions to filter user-created submissions
  • Added a new column is_draft in the application table - to identify drafts (is_draft=default false) - previously Draft status was used to filter out drafts for applications - Code cleanup related to these in other services needs to be done
  • Alembic script added to mark existing active drafts to is_draft true in application table done.
  • On draft creation is_draft set to true & on draft submit set to false

Screenshots

image
With parentformId filter
image
With includeDrafts=true filter
image
With onlyDrafts=true filter
image

Checklist

  • Updated changelog
  • Added meaningful title for pull request

@auslin-aot auslin-aot force-pushed the feature/fwf-3749-application-get-api-changes branch from 37c5b90 to 725f739 Compare January 20, 2025 07:19
@auslin-aot auslin-aot force-pushed the feature/fwf-3749-application-get-api-changes branch from 6682acf to 32d8876 Compare January 20, 2025 08:44
@auslin-aot auslin-aot marked this pull request as ready for review January 20, 2025 08:52
@auslin-aot auslin-aot requested review from a team as code owners January 20, 2025 08:52
@@ -26,7 +26,7 @@ ecdsa==0.19.0
flask-jwt-oidc==0.7.0
flask-marshmallow==1.2.1
flask-restx==1.3.0
formsflow_api_utils @ git+https://github.com/AOT-Technologies/forms-flow-ai.git@develop#subdirectory=forms-flow-api-utils
formsflow_api_utils @ git+https://github.com/auslin-aot/forms-flow-ai.git@feature/fwf-3749-application-get-api-changes#subdirectory=forms-flow-api-utils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this branch be changed to develop during merge? @auslin-aot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes after merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants