Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FWF-4180: [Modified] Updated Internationalization #2532

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

FWF-4180: [Modified] Updated Internationalization #2532

wants to merge 4 commits into from

Conversation

Aaliya-AOT
Copy link

Issue Tracking

JIRA: https://aottech.atlassian.net/browse/FWF-4180
Issue Type: BUG/ FEATURE

Changes

  • Added Translation

Screenshots (if applicable)

image

Notes

Checklist

  • Updated changelog
  • Added meaningful title for pull request

@Aaliya-AOT Aaliya-AOT requested review from a team as code owners January 17, 2025 08:14
@arun-s-aot
Copy link
Contributor

Are you using any vs code formatters @Aaliya-AOT ?
Seems like there are quite lot changes in different files more than what is needed. mostly as new lines, empty spaces . We can connect some time to discuss that. it can create mergeconflicts also if not handled.

@Bonymol-aot Bonymol-aot marked this pull request as draft January 20, 2025 09:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Aaliya-AOT
Copy link
Author

Are you using any vs code formatters @Aaliya-AOT ? Seems like there are quite lot changes in different files more than what is needed. mostly as new lines, empty spaces . We can connect some time to discuss that. it can create mergeconflicts also if not handled.

Disabled prettier extension.

@Aaliya-AOT Aaliya-AOT marked this pull request as ready for review January 20, 2025 10:45
shuhaib-aot
shuhaib-aot reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@shuhaib-aot shuhaib-aot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold this pr , we can check micro front end and confirm where the translation need

forms-flow-web/src/components/Form/EditForm/FormEdit.js
primaryBtnText: "Unpublish and Edit This Form",
secondaryBtnText: "Cancel, Keep This Form Unpublished",
primaryBtnText: t("Unpublish and Edit This Form"),
secondaryBtnText: t("Cancel, Keep This Form Unpublished"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check this, because custom components having translation in microfront end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuhaib-aot shuhaib-aot shuhaib-aot left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aaliya-AOT @arun-s-aot @shuhaib-aot