Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding hidden fields #2342

Merged
merged 8 commits into from
Nov 20, 2024
Merged
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 65 additions & 43 deletions forms-flow-web/src/components/PrivateRoute.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
/* eslint-disable no-unused-vars */
import React, { useEffect, Suspense, lazy, useMemo, useCallback } from "react";
import React, {
useEffect,
Suspense,
lazy,
useMemo,
useCallback,
useState,
} from "react";
import { Route, Switch, Redirect, useParams } from "react-router-dom";
import { useDispatch, useSelector } from "react-redux";
import {
@@ -52,7 +59,8 @@ import { AppConfig } from "../config";
import { getFormioRoleIds } from "../apiManager/services/userservices";
import AccessDenied from "./AccessDenied";
import { LANGUAGE } from "../constants/constants";
import useUserRoles from "../constants/permissions";
import useUserRoles from "../constants/permissions";
import { getUserRoles } from "../apiManager/services/authorizationService"; // Assuming you have a service to get roles

export const kcServiceInstance = (tenantId = null) => {
return KeycloakService.getInstance(
@@ -83,30 +91,29 @@ const PrivateRoute = React.memo((props) => {
const [authError, setAuthError] = React.useState(false);
const [kcInstance, setKcInstance] = React.useState(getKcInstance());
const [tenantValid, setTenantValid] = React.useState(true); // State to track tenant validity

const {
admin,
createDesigns ,
createSubmissions ,
viewDesigns ,
viewSubmissions ,
viewTasks,
manageTasks,
viewDashboards
} = useUserRoles();
const BASE_ROUTE_PATH = (viewTasks || manageTasks)
? `${redirecUrl}task`
: ( createSubmissions || createDesigns || viewDesigns)
? `${redirecUrl}form`
: admin
? `${redirecUrl}admin`
: viewSubmissions
? `${redirecUrl}application`
: viewDashboards
? `${redirecUrl}metrics`
: "/404";
admin,
createDesigns,
createSubmissions,
viewDesigns,
viewSubmissions,
viewTasks,
manageTasks,
viewDashboards,
} = useUserRoles();

const BASE_ROUTE_PATH =
viewTasks || manageTasks
? `${redirecUrl}task`
: createSubmissions || createDesigns || viewDesigns
? `${redirecUrl}form`
: admin
? `${redirecUrl}admin`
: viewSubmissions
? `${redirecUrl}application`
: viewDashboards
? `${redirecUrl}metrics`
: "/404";

const authenticate = (instance, store) => {
setKcInstance(instance);
@@ -151,6 +158,22 @@ const PrivateRoute = React.memo((props) => {
}
}, [props.store, kcInstance, tenantId]);

// Remove this line since 'allRoles' is not used elsewhere
// const [allRoles, setAllRoles] = useState([]);

// Updated useEffect to fetch and set user roles without the 'allRoles' assignment
useEffect(() => {
getUserRoles()
.then((res) => {
if (res) {
const { data = [] } = res;
const roles = data.map((role) => role.name);
localStorage.setItem("AllUserRoles", JSON.stringify(roles)); // Set roles in localStorage
}
})
.catch((error) => console.error("Error fetching roles", error));
}, [dispatch]);

useEffect(() => {
if (tenantId && MULTITENANCY_ENABLED) {
validateTenant(tenantId)
@@ -230,18 +253,21 @@ const PrivateRoute = React.memo((props) => {
const FormRoute = useMemo(
() =>
({ component: Component, ...rest }) =>
(
<Route
{...rest}
render={(props) =>
createDesigns || viewDesigns || createSubmissions || viewSubmissions ? (
<Component {...props} />
) : (
<AccessDenied userRoles={userRoles} />
)
}
/>
),
(
<Route
{...rest}
render={(props) =>
createDesigns ||
viewDesigns ||
createSubmissions ||
viewSubmissions ? (
<Component {...props} />
) : (
<AccessDenied userRoles={userRoles} />
)
}
/>
),
[userRoles]
);

@@ -355,13 +381,9 @@ const PrivateRoute = React.memo((props) => {
component={ServiceFlow}
/>
)}
<Route exact path={`${redirecUrl}admin`} />
<Route exact path={`${redirecUrl}admin`} />
<Route exact path={BASE_ROUTE}>
{userRoles.length && (
<Redirect
to={BASE_ROUTE_PATH}
/>
)}
{userRoles.length && <Redirect to={BASE_ROUTE_PATH} />}
</Route>
<Route path="/404" exact={true} component={NotFound} />
<Redirect from="*" to="/404" />
Loading