Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BPM Abstraction #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

BPM Abstraction #5

wants to merge 2 commits into from

Conversation

sumesh-aot
Copy link
Member

@sumesh-aot sumesh-aot commented Oct 20, 2022 •
edited
Loading

@sumesh-aot sumesh-aot marked this pull request as ready for review October 21, 2022 20:53
@sumesh-aot sumesh-aot requested a review from a team October 21, 2022 20:53
sreehari-aot
sreehari-aot reviewed Oct 25, 2022
View reviewed changes
Copy link

@sreehari-aot sreehari-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change cause the BPM engine to rely on the abstraction layer to fulfill the core BPM features? Are there any suggestions to overcome the mentioned performance implications?

@sumesh-aot
Copy link
Member Author

Does this change cause the BPM engine to rely on the abstraction layer to fulfill the core BPM features? Are there any suggestions to overcome the mentioned performance implications?

We are not planning to change any core BPM engine features, abstraction layer is only on the rest layer. We will parse the default BPM request/response and provide request/response as in the API Spec designed (link in rfc), then make our web and api to work with these API spec.
Any non-BPM features like filters, authorizations etc. we will capture on our API, then use the Java (or any other language) API provided by BPM layer to accomplish our use cases.

@sreehari-aot sreehari-aot self-requested a review October 25, 2022 08:22
sreehari-aot
sreehari-aot approved these changes Oct 25, 2022
View reviewed changes
Copy link

@sreehari-aot sreehari-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

SnehaSuresh-aot
SnehaSuresh-aot reviewed Nov 29, 2022
View reviewed changes
rfcs/bpm_abstraction/bpm_api_spec.yaml
tags: []
responses: {}
operationId: get-process-instance-id-instances
/filters/tasks:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint has modified to /task-filters in the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SnehaSuresh-aot SnehaSuresh-aot SnehaSuresh-aot left review comments

@sreehari-aot sreehari-aot sreehari-aot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumesh-aot @SnehaSuresh-aot @sreehari-aot