Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fwf 3844 no code UI #326

Conversation

saneesh-aot
Copy link
Contributor

Issue Tracking

JIRA:
Issue Type: BUG/ FEATURE

Changes

Added CSS changes in the MainOptionModal component, including padding and flex direction adjustments.
Screenshot 2024-11-05 025059

Copy link

sonarqubecloud bot commented Nov 5, 2024

@arun-s-aot
Copy link
Contributor

can you please revert package-lock file commit.

@@ -56,7 +55,7 @@
}

.modal-content-heading {
color: var(--ff-base-600, #253DF4);
color: var(--ff-base-600, #253df4);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove default value in variable

@@ -186,7 +184,7 @@
margin-top: 2.5vh !important;
margin-bottom: 2.5vh !important;
height: 95vh;
background: var(--ff-white, #FFF);
background: var(--ff-white, #fff);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove default value in variable

@@ -197,14 +195,14 @@
.tab-content {
padding: var(--spacer-100) var(--spacer-125);
width: 100% !important;
background: var(--ff-gray-000, #F2F2F3);
background: var(--ff-gray-000, #f2f2f3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove default value in variable

}

.node-listing-modal {
padding: 2rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var(--spacer-200)

align-self: stretch;
}
}

.main-options {
padding: 2rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var(--spacer-200)

padding: 2rem;
display: flex;
flex-direction: column;
gap: 1rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var(--spacer-100)

@arun-s-aot
Copy link
Contributor

Please connect with Ajay and use the compoennt he used so that we can avoid this PR @saneesh-aot

@arun-s-aot arun-s-aot closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants