make hostname update as optional #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine to me.... @soupdiver seems like you've been following this thread? care to merge? |
|
I like this concept, but it changes the default behavior of the role. @soupdiver thoughts ? |
|
Like |
|
Agree with @otakup0pe that we should keep the behaviour backwards compatible. |
TinOo512
force-pushed
the
krashstudio/meta
branch
from
e2abddc to
20ef570
Compare
|
@soupdiver done :) |
|
LGTM |
|
If we can get the conflict dealt with I'll totally merge this. Also if y'all are interested in helping formally maintain this role, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved the work of @welcoMattic (#48) in our organisation.
So this PR is now split and clean.