This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fix chop function #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same as #6 this is from the visjs library itself but I think it can be a nice bug fix for this, located here: https://github.com/almende/vis/blob/develop/lib/network/dotparser.js#L708 |
|
Ah yes, I see. Is the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chop length seems to be hardcoded to 27, ignoring the maxLength parameter.
I believe the intention is normally for the maxLength to be 30, and we take away 3 from the maxLength to accomodate the
.... I'm not sure where this is used but noticed when trying to resolve another issue :)