EB-FlowOverCylinder Case #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baperry2
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Let's have this case run as part of the testing suite, but only in 2D. To do that, put
if(PELE_DIM EQUAL 2)
add_test_r(EB-FlowPastCylinder EB-FlowPastCylinder)
endif()
here: https://github.com/AMReX-Combustion/PeleC/blob/development/Tests/CMakeLists.txt#L242
Also, can you add entry to the documentation for this case similar to the other EB cases here? https://github.com/AMReX-Combustion/PeleC/tree/development/Docs/sphinx/ebverification. For the documentation, snapshots from a case with 5 < Re < 47 showing steady flow and a case with 47 < Re < 500 showing a vortex shedding would be enough for validation.
… added to testing suite.
baperry2
requested changes
Jul 22, 2024
baperry2
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a case that flows Hagen–Poiseuille flow over a cylinder defined with embedded boundaries. The case utilizes the Godunov method instead of the MOL.