ParamParse: Find Entries under Prefix

[ax3l]

Summary

Extend the "unused params" checks to find generally parameters under a given inputs prefix.

Additional background

Demonstrator & test in: AMReX-Codes/amrex-tutorials#7

Checklist

The proposed changes:

• fix a bug or incorrect behavior in AMReX
• add new capabilities to AMReX
• changes answers in the test suite to more than roundoff level
• are likely to significantly affect the results of downstream AMReX users
• are described in the proposed changes to the AMReX documentation, if appropriate

[jmsexton03]

Consider found_enties => found_entries
While you're adding flags, did you want to add a flag to leverage the duplicate resolution behavior of ParmParse? It looks like this may give you a list of all matching entries, not all unique or last matching entries. ppindex uses a reversed iterator in order to take the last entry. I'm good either way.

[ax3l]

Thanks, fixed the typo!

While you're adding flags, did you want to add a flag to leverage the duplicate resolution behavior of ParmParse?

I think I don't know what that is, but the test I did for my use case in AMReX-Codes/amrex-tutorials#7 works well :)

[WeiqunZhang]

It is allowed to have multiple entries in a ParmParse input file. For example

a = 2
a = 3
a = 4

By default, ParmParse::get and query returns the last one. The new getEntries function will return a vector with a appearing 3 times. I think this is what @jmsexton03 is talking about.

[ax3l]

Thanks, got it!

For my current use case, it's not problematic that duplicates are returned because I'll query their values with the usual get and query calls :)
But if it's clearner, I can add the values to an (unordered_)set if you like?

[jmsexton03]

Thanks for clarifying my question @WeiqunZhang, I think the tutorial update mentioned above wouldn't have shown the multiple entries case since it doesn't use an input file.
Using a set sounds clearer than a vector to me, but I don't have a strong preference.

[ax3l]

I'll use a set then over an unordered_set. The former is more expensive, but the sorting comes handy for use cases like sorting for sub-sub options later on.