Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drcov path parsing #2884

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Fix drcov path parsing #2884

wants to merge 22 commits into from

Conversation

rmalmain
Copy link
Member

also, apply suggestion in #2883 from @domenukk.

@rmalmain rmalmain requested a review from domenukk January 22, 2025 17:00
@rmalmain
Copy link
Member Author

i changed a bit clippy config:

  • i allowed what was considered as warning before, to reduce the noise.
  • warnings are treated as errors. that way, we detect multiple errors that were silenced before

libafl/src/lib.rs Outdated Show resolved Hide resolved
libafl_bolts/src/lib.rs Outdated Show resolved Hide resolved
@domenukk
Copy link
Member

If it's only happening on some architectures or configs, maybe make it allow but add a comment?

@rmalmain
Copy link
Member Author

we have this problem for negative_feature_names and multiple_crate_versions, which are lints independent of the config or the architecture.
it keeps spamming the output of clippy, but either it's on purpose or there is nothing we can do to fix them.
i propose we just keep them as allowed for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants