-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Use docker hub auto build #36
base: develop
Are you sure you want to change the base?
Conversation
Here is some docu I would like to not forget |
afab31c
to
db96c10
Compare
…to README and use by docker-hub-auto-build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot agree with this PR, I don't see the point of having many scripts outside the Dockefile.
If the git-lfs is not installed, as far I understood, with a hook you could install it before downloading the repository and everything is still working, right?
Like this, but:
yum install -y git-lfs
# OR
apt-get install -y git-lfs
git submodule update --init --recursive
I did not manage to get a hook before the first The first time I was able to get a hook was |
So ... regarding your comment here.
I think I explained the reasons for going the way I went in this PR. What you proposed, installing git-lfs via I think in engineering, when one path works .. and the other path does not work ... well there might not be too much to discuss. |
@@ -54,8 +59,7 @@ RUN yum install -y autoconf \ | |||
yum clean all && \ | |||
# Prepare Java | |||
mkdir -pv /usr/java && \ | |||
ln -sv /usr/lib/jvm/java-openjdk $JAVA_HOME && \ | |||
echo "source $ACS_ROOT/ACSSW/config/.acs/.bash_profile.acs" >> /etc/bashrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this removal related to #37 ?
I tested how what is needed for us to use the Docker Hub Automated Builds Feature.
These were the "sub-issues" I ran into:
On DockerHub Configure Automated Builds I (dneise) cannot select the ACS-Docker-Image repository, which is owned by ACS-Community.
So for the moment, I simply forked our repo to my personal account and played with that.
I assume @tstaig can do it. So for now its fine .. and once we like it .. Thomas can just do it.
The VM they (docker-hub) use for building the images does not have git-lfs installed at the time they do the
git clone
.So I had to fall back to a hook. I simply chose the
hooks/post_checkout
for this.So, we have no real advantage of using a sub-module anymore. So I replaced it with a little
git_clone_acs.sh
script.In order for us, to make advancing to a new version of ACS as easy as possible, I've introduced a little text file called
VERSION
. If we are lucky and nothing in the build changes between two versions of ACS .. we only modify that file and are done.