-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for xunit v3 #115
Merged
Support for xunit v3 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Activate GitHub Actions test reporting
Revert "Merge pull request #319 from AArnott/betterTestingLibTemplate"
Update .NET SDK and xunit.runner.visualstudio
Bump to Xunit v3
Specifically, this merges [867012d from that repo](AArnott/Library.Template@867012d).
Specifically, this merges [867012d from that repo](AArnott/Library.Template@867012d).
Merge latest Library.Template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 11 changed files in this pull request and generated 2 comments.
Files not reviewed (6)
- Directory.Packages.props: Language not supported
- global.json: Language not supported
- src/Xunit.Combinatorial/Xunit.Combinatorial.csproj: Language not supported
- test/Xunit.Combinatorial.Tests/Xunit.Combinatorial.Tests.csproj: Language not supported
- version.json: Language not supported
- docfx/docs/toc.yml: Evaluated as low risk
Comments suppressed due to low confidence (1)
test/Xunit.Combinatorial.Tests/CombinatorialDataAttributeTests.cs:188
- The 'await' keyword should be used properly to ensure asynchronous operations are handled correctly.
private static async Task AssertData(IReadOnlyCollection<object?[]> expectedCombinatorial, [CallerMemberName] string? testMethodName = null)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113