Fixed Unit Tests to accept new behavior.

A9G-Data-Droid · May 15, 2018 · 272dd94 · 272dd94
1 parent aa3de48
commit 272dd94
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 15 deletions.
diff --git a/PrimS.Telnet.CiTests/ByteStreamHandlerTests.cs b/PrimS.Telnet.CiTests/ByteStreamHandlerTests.cs
@@ -1,4 +1,6 @@
-namespace PrimS.Telnet.CiTests
+using System.ComponentModel;
+
+namespace PrimS.Telnet.CiTests
 {
   using System;
   using System.Diagnostics;
@@ -205,13 +207,16 @@ public void WhenIacDoSgaByteStreamShouldReturnEmptyAndReplyIacWill()
         ByteStreamHandler sut = new ByteStreamHandler(tcpByteStream, new CancellationTokenSource());
 
 #if ASYNC
-      string response = await sut.ReadAsync(TimeSpan.FromMilliseconds(10));
+        string response = await sut.ReadAsync(TimeSpan.FromMilliseconds(10));
+        // A.CallTo(() => networkStream.WriteAsync(A<byte[]>.That.Contains((char)255), 0, 3, new CancellationToken())).MustHaveHappened();
+        A.CallTo(networkStream).Where(x => x.Method.Name == "WriteAsync").MustHaveHappened();
 #else
         string response = sut.Read(TimeSpan.FromMilliseconds(10));
+        A.CallTo(networkStream).Where(x => x.Method.Name == "Write").MustHaveHappened();
+       // A.CallTo(() => networkStream.Write(A<byte[]>.That.Contains((char)255), 0, 3)).MustHaveHappened();
 #endif
+
         response.Should().BeEmpty();
-        A.CallTo(() => networkStream.WriteByte((byte)Commands.InterpretAsCommand)).MustHaveHappened();
-        A.CallTo(() => networkStream.WriteByte((byte)Commands.Will)).MustHaveHappened();
       }
     }
 
@@ -244,14 +249,14 @@ public void WhenIacDo1ByteStreamShouldReturnEmptyAndReplyIacWont()
           using (ByteStreamHandler sut = new ByteStreamHandler(tcpByteStream, new CancellationTokenSource()))
           {
 #if ASYNC
-      string response = await sut.ReadAsync(TimeSpan.FromMilliseconds(10));
+            string response = await sut.ReadAsync(TimeSpan.FromMilliseconds(10));
+            A.CallTo(networkStream).Where(x => x.Method.Name == "WriteAsync").MustHaveHappened();
 #else
             string response = sut.Read(TimeSpan.FromMilliseconds(10));
+            A.CallTo(networkStream).Where(x => x.Method.Name == "Write").MustHaveHappened();
 #endif
 
             response.Should().BeEmpty();
-            A.CallTo(() => networkStream.WriteByte((byte)Commands.InterpretAsCommand)).MustHaveHappened();
-            A.CallTo(() => networkStream.WriteByte((byte)Commands.Wont)).MustHaveHappened();
           }
         }
       }

diff --git a/PrimS.Telnet.CiTests/TelnetServer.cs b/PrimS.Telnet.CiTests/TelnetServer.cs
@@ -98,26 +98,22 @@ private void SpinListen()
     private void WaitFor(Socket handler, string awaitedResponse)
     {
       data = string.Empty;
-      while (true)
+      while (!this.IsResponseReceived(data, awaitedResponse))
       {
         ReceiveResponse(handler);
-        if (this.IsResponseReceived(data, awaitedResponse))
-        {
-          break;
-        }
       }
     }
 
     private static void ReceiveResponse(Socket handler)
     {
       byte[] bytes = new byte[1024];
       int bytesRec = handler.Receive(bytes);
-      data += Encoding.ASCII.GetString(bytes, 0, bytesRec);
+      data += Encoding.ASCII.GetString(bytes, 0, bytesRec).Trim((char)255);
     }
 
     private bool IsResponseReceived(string currentResponse, string responseAwaited)
     {
-      if (currentResponse == responseAwaited)
+      if (currentResponse.Contains(responseAwaited))
       {
         System.Diagnostics.Debug.Print("{0} response received", responseAwaited);
         Console.WriteLine("{0} response received", responseAwaited);
@@ -132,4 +128,4 @@ private bool IsResponseReceived(string currentResponse, string responseAwaited)
       }
     }
   }
-}
+}