-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Volume Controller #13
Conversation
First off, thank you for these PRs! This comment addresses both #13 and #14. The code updates seem fine at first glance, however before taking a closer look I would like to ask you to fix the formating. Notice that a lot of extra lines has been changed (see the diff) due to whitespace changes. |
Got it, i forgot to deactivate the default usage of prettier and that formatted all the files by default, sorry. |
Okay, I believe this branch now only includes the necessary changes made to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested these changes?
Can you also commit the package-lock.json
file. This will help when building in the future.
I have tested the changes, and setting the volume to values above 15 produces very loud sounds, while setting a volume of 0.01 produces very low sounds, which is working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Because I can't get it to install on my PC right now (some npm issue), but I'll trust you that it works 👍
Great work! Thank you!
This pull request addresses issue #4 by adding a volume control feature to the extension. Users can now adjust the volume of the voice lines played by the extension.