Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button expander #411

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft

Button expander #411

wants to merge 38 commits into from

Conversation

danngreen
Copy link
Member

@danngreen danngreen commented Oct 11, 2024

Adds support for Button Expanders

The button lights and button itself are separate entities in the patch file, but the GUI should help keep them in sync (perhaps an override can be done to choose any LED to map to)

TODO:

  • Allow mapping to the buttons in MM. GUI thread needs access to metaparams.button_events
  • When creating a mapping in MM, determine the light to map to:
    • Check the module's info struct, see if the param element has counts.num_lights > 0
    • If not, then scan elements for one with counts.num_lights > 0 and an intersecting box (x/y_mm + width/height_mm)
  • When removing a button mapping, remove the light mapping as well
  • Add Button Expander to VCV
  • Allow mapping to buttons in VCV
  • Allow mapping lights
    • scan module's lightInfo's and look for one whose box intersects the param's box
    • Also add right-click menu so the user can select a different light on the module: just let the use pick a number from 1 to lightInfo.size(). Users can try one and see if they like it.

Future ideas to consider (create issues when closing this if we want to purse these):

  • Mapping a button to an RGB button can take the average of RGB elements and turn on if they are over a threshold
  • Allow user to choose which light to map to (including average of multiple lights)

@danngreen danngreen marked this pull request as draft October 16, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant