Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wifi remaining features #329

Merged
merged 16 commits into from
Sep 26, 2024
Merged

Wifi remaining features #329

merged 16 commits into from
Sep 26, 2024

Conversation

LnnrtS
Copy link
Collaborator

@LnnrtS LnnrtS commented Aug 14, 2024

Integration branch for remaining wifi features until release of the wifi module

  • Patches in subfolders
  • Display more information about patchfiles
  • Creation of folders
  • More operation on patches
  • Download patch files to browser
  • Client side processing based features
    • Show used modules

Some of that is waiting on #342

Base automatically changed from fix_missing_include_dir to main August 15, 2024 20:34
@LnnrtS LnnrtS marked this pull request as ready for review August 23, 2024 12:30
@danngreen
Copy link
Member

I have to insert some delays in the esp_loader_flash_defl_start() function in order to get it to work, otherwise it always fails with

Flash size detection failed, falling back to defaultError: COMMAND_FAILED
Cannot start flashing wifi

With the delays, it will fail if the wifi application firmware is written right before the filesystem with DEFLATE_ERROR.
If the wifi app does not have to be written (checksum matches, or is not present in the manifest) then filesystem flashing works. It behaves similar to the #259 (only works the second time you flash) but the errors are different, so I don't think it's the same issue.

The fix/workaround I found was to switch the order of the files in the json manifest. Then I can flash both the application and the filesystem.

I'm not comfortable with how fragile this is, but it's working every time with these changes. There must be some issue with the ESP loader changing state between non-compressed and compressed?

My plan to is to keep testing and make the file order change in the manifest generator.

@danngreen
Copy link
Member

I merged in more of #282 (skips Wifi modules without an error if not connected and reports it on screen)

@danngreen danngreen merged commit 6136dfe into main Sep 26, 2024
@danngreen danngreen deleted the wifi_remaining_features branch September 27, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants