edit 3d tiles opacity and blending mode

[kfarr]

No description provided.

[vincentfretin]

That's expensive to keep doing a traverse on each tick, also it's creating an array each time [node.material].

[kfarr]

You're right, in obb-clipping this is throttled, I can do that again.

[kfarr]

Unfortunately the result looks very bad if throttled, materials appear to "flicker" as they wait for the throttle to be adjusted to a different blending.

For now I'll keep it, but there are 2 options to fix:

1. hook into the material post processing event in the existing 3d tiles library
2. consider switching to better maintained library instead of optimizing this one, hook into its material post processing event https://github.com/NASA-AMMOS/3DTilesRendererJS?tab=readme-ov-file#custom-material (blocked by a-frame / three.js upgrade -- needs v166)

[kfarr]

the default should not apply this unless a user selects it. an idea:

• add new boolean to street-geo, blendingEnabled default false
• if false, don't add or modify any blending-opacity component values
• if set to true and was previously false, add blending-opacity component, allow modify of blending-opacity component values
• if set to false and was previously true, delete and re-add the google tiles without the component?

[vincentfretin]

Wait, for the array allocation, I just thought that you will fix it like this:

3dstreet/src/components/polygon-offset.js

Lines 23 to 48 in 40ace74

	applyPolygonOffsetToObject: function (object3D) {
	if (!object3D) return;
	object3D.traverse((obj) => {
	if (obj.isMesh) {
	if (Array.isArray(obj.material)) {
	obj.material.forEach((material) => {
	this.updateMaterial(material);
	});
	} else {
	this.updateMaterial(obj.material);
	}
	}
	});
	},
	updateMaterial: function (material) {
	if (!material) return;
	material.polygonOffset = true;
	material.polygonOffsetFactor = this.data.factor;
	material.polygonOffsetUnits = this.data.units;
	// Ensure material updates
	material.needsUpdate = true;
	},

Not a complex cache with a WeakMap.

For traversing of each tick, it probably doesn't matter much, you can do a Chrome profiling eventually with cpu throttling with and without the component to be sure.
You can revisit the code once we update aframe and use the proper hook/event the 3d tiles library provides.