attempt to fix uniqueID issue

3DStreet · Jan 24, 2025 · be486ea · be486ea
1 parent 4726a6e
commit be486ea
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 16 deletions.
diff --git a/src/editor/lib/commands/EntityCloneCommand.js b/src/editor/lib/commands/EntityCloneCommand.js
@@ -10,17 +10,17 @@ export class EntityCloneCommand extends Command {
     this.name = 'Clone Entity';
     this.updatable = false;
     if (!entity.id) {
-      entity.id = createUniqueId();
+      entity.id = createUniqueId(); // if entity to clone doesn't have an id, create one
     }
-    this.entityIdToClone = entity.id;
-    this.entityId = null;
+    this.entityIdToClone = entity.id; // save the id of the entity to clone
+    this.entityId = null; // this will be the id of the newly cloned entity
   }
 
   execute(nextCommandCallback) {
     const entityToClone = document.getElementById(this.entityIdToClone);
     if (entityToClone) {
-      const clone = cloneEntityImpl(entityToClone, this.entityId);
-      this.entityId = clone.id;
+      const clone = cloneEntityImpl(entityToClone, this.entityId); // why is this.entityId passed? will this always be null?
+      this.entityId = clone.id; // use ID set by cloneEntityImpl function
       nextCommandCallback?.(clone);
       return clone;
     }

diff --git a/src/editor/lib/entity.js b/src/editor/lib/entity.js
@@ -155,20 +155,14 @@ export function cloneEntityImpl(entity, newId = undefined) {
     { once: true }
   );
 
+  // In cloneEntityImpl
   if (newId) {
     clone.id = newId;
+  } else if (entity.id) {
+    clone.id =
+      entity.id.length === 21 ? createUniqueId() : getUniqueId(entity.id);
   } else {
-    if (entity.id) {
-      if (entity.id.length === 21) {
-        // nanoid generated id, create a new one
-        clone.id = createUniqueId();
-      } else {
-        // Get a valid unique ID for the entity
-        clone.id = getUniqueId(entity.id);
-      }
-    } else {
-      entity.id = createUniqueId();
-    }
+    clone.id = createUniqueId();
   }
   insertAfter(clone, entity);
   return clone;