Issue 3342 - RFE logconv.pl should have a replacement in CLI tools #6444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchapma
added
the
work in progress
progier389
approved these changes
Dec 13, 2024
| self.notesA = {} | ||
| self.notesF = {} | ||
| self.notesP = {} | ||
| self.notesU = {} |
There was a problem hiding this comment.
There is now a "notes=M" for MFA
|
Looks fundamentally good (at least at the design level) [1] IMHO you should clean up the style before the first commit: reports lots of issues (mostly about spaces) (BTW: I ignored the long line because IMHO keeping the long error message in a single line is painful but more readable and less error prone than splitting them) |
Bug description: Perl DB is not available in RHEL 10 so the server access log analyzer tool (logconv.pl) needs to be ported to python. Fix description: Initial draft of logconv.py, this is a work in progress. This commit message will be updated following code review/rework. Fixes: 389ds#3342 Reviewed by:
logging, recommentations, other tidy up
Makefile.am, 389-ds-base.spec.in, more tidy up, removed connection group layer, even more tidy up, processed time hours bug, file order bug
jchapma
added a commit
that referenced
this pull request
Jan 23, 2025
…6444) Bug description: Perl DB is not available in RHEL 10 so the server access log analyzer tool (logconv.pl) needs to be ported to python. Fix description: Initial draft of logconv.py, this is a work in progress. This commit message will be updated following code review/rework. Fixes: #3342 Reviewed by: @progier389 @mreynolds389 (Thank you)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description:
Perl DB is not available in RHEL 10 so the server access log
analyzer tool (logconv.pl) needs to be ported to python.
Fix description:
Initial draft of logconv.py, this is a work in progress. This
commit message will be updated following code review/rework.
Fixes: #3342
Reviewed by: