Issue 6436 - MOD on a large group slow if substring index is present #6437
Conversation
Bug Description: If the substring index is configured for the group membership attribute ( member or uniqueMember ), the removal of a member from a large static group is pretty slow. Fix Description: A solution to this issue would be to introduce a new index to track a membership atttribute index. In the interm, we add a check to healthcheck to inform the user of the implications of this configuration. Fixes: 389ds#6436 Reviewed by:
| standalone = topology_st.standalone | ||
|
|
||
| log.info('Enable MO plugin') | ||
| plugin = MemberOfPlugin(standalone) |
There was a problem hiding this comment.
Is it required to enable memberof ?
IMHO healthcheck should only warn when a membership attribute is indexed in substring, independently of memberof being enabled/disabled
There was a problem hiding this comment.
We discussed this on Tuesday and decided that is was easier to check for this configuration from the memberof plugin, similar to the check for the equality index type.
src/lib389/lib389/plugins.py
Outdated
| report['fix'] = report['fix'].replace('YOUR_INSTANCE', self._instance.serverid) | ||
| report['items'].append(suffix) | ||
| report['items'].append(attr) | ||
| report['check'] = f'memberof:substring_index' |
There was a problem hiding this comment.
Why 'memberof' ? I would expect the admin to check the need of 'attr' substring_index
There was a problem hiding this comment.
Good point, I will change this
src/lib389/lib389/plugins.py
Outdated
| report['fix'] = report['fix'].replace('YOUR_INSTANCE', self._instance.serverid) | ||
| report['items'].append(suffix) | ||
| report['items'].append(attr) | ||
| report['check'] = f'memberof:substring_index' |
src/lib389/lib389/plugins.py
Outdated
| backends = Backends(self._instance).list() | ||
| attrs = self.get_attr_vals_utf8_l("memberofgroupattr") | ||
| container = self.get_attr_val_utf8_l("nsslapd-plugincontainerscope") | ||
| #import pdb; pdb.set_trace() |
src/lib389/lib389/plugins.py
Outdated
| except: | ||
| # No index at all, bad |
There was a problem hiding this comment.
If it's a 'No index at all' error, I think, we should be more specific with the except: and specify the exact exception expected.
There was a problem hiding this comment.
I copied this from other memberof attr checks, but you're right. This test is to check if a membership attribute contains a substring index, if the index doesn't exist then we have nothing to report.
src/lib389/lib389/plugins.py
Outdated
| except: | ||
| pass |
There was a problem hiding this comment.
No, what I mean is that we should not handle bare exceptions like that (and in Python, in general).
I think it should follow this logic (it's just an example, the actual exceptions should be something else):
try:
result = check()
except ValueError:
handle_value_error()
except TypeError:
handle_type_error()
Bug Description: If the substring index is configured for the group membership attribute ( member or uniqueMember ), the removal of a member from a large static group is pretty slow.
Fix Description: A solution to this issue would be to introduce a new index to track a membership atttribute index. In the interm, we add a check to healthcheck to inform the user of the implications of this configuration.
Fixes: #6436
Reviewed by: