Issue 4596 - Build with clang/lld fails when LTO enabled #6392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a copy of #4929 which got closed when I recreated my fork. Last time there was an issue building with gcc. I tried today to build it on F40 and the build was successful. So giving it another try. |
|
gcc compilation pipeline failed with: |
|
Pipeline is fixed, compilation with gcc is now successful. |
droideck
approved these changes
Nov 5, 2024
Bug Description: Fedora is introducing lto by default which may affect our build especially with rust and asan Fix Description: Adapt how we use lto and how we link in our builds so that lto works for gcc. fixes: 389ds#4596 Author: William Brown <[email protected]> Review by: ???
Bug Description: Build with clang/lld fails with undefined reference error. ``` ld.lld: error: ./.libs/libslapd.so: undefined reference to __rust_probestack [--no-allow-shlib-undefined] ld.lld: error: ./.libs/libslapd.so: undefined reference to __muloti4 [--no-allow-shlib-undefined] ``` Fix Description: * Disabled GCC security flags when building with clang. * lld by default uses xxhash for build ids, which is too small for rpm (it requires it between 16 and 64 bytes in size), use sha1 instead. * Switch debug CFLAGS and LDFLAGS to use DWARF4 instead of DWARF5. * Disable LTO for clang rpm build. Fixes: 389ds#4596 Reviewed by: @droideck (Thanks!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 4596 - Build with clang/lld fails when LTO enabled
Bug Description:
Build with clang/lld fails with undefined reference error.
Fix Description:
(it requires it between 16 and 64 bytes in size), use sha1 instead.
Fixes: #4596
Reviewed by: ???