-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 4896 - improve CI tests report in case of SERVER_DOWN exception #4897
Conversation
In the first few test I looked at, the SERVER_DOWN was coming after a MDB_MAP_FULL error The 1GB default limit is probably too small |
… 4 - increase default map size
Can you provide an example of what this output will look like in a failure case? I think it's a really good idea though. |
Hi William, Note: I think I will change the way to discover the topologies (looking up for all existing dse.ldif seems a better idea) because current code does not provide any feedback on failed setup |
… 4 - improve lmdb_nasty logs
That's actually really impressive and looks great. If there is a crash it may also be worth listing the asan log dir?
A failed setup is a bit of a tricky case, but couldn't that be covered in the topology setup code to capture when an exception happens and then trigger the same routines to display the info? |
I agree, asan results should be logged too .
In fact according to my test, the current code already capture the setup exception, That is why I think that I should walk all dse files and generate the associated offline DirServ rather than registering the created topologies in a list |
I dusted off and rebased my PR #4625 that adds ASAN pipeline and logs results as an artifact. |
In that case ack from me @progier389 :) @vashirov I'll review that seperately :) |
… 4 - fix err 22 issue by refactoring the instance management
… 4 - fix err 22 issue by refactoring the instance management
… ldap.SERVER_DOWN exception
… ldap.SERVER_DOWN exception
… ldap.SERVER_DOWN exception
… ldap.SERVER_DOWN exception
… ldap.SERVER_DOWN exception
… ldap.SERVER_DOWN exception
Added asan sections and dbscan -L output (which IMHO could be useful when getting out of disk or db map size because the number of records per db instance is listed) |
** Description **
These first change implements an hook that add some data in the report if a test fails with ldap.SERVER_DOWN exception
(Typically a SERVER_DOWN section is added that contains ns-slapd core files digest and extract of important message from error log)
This also change the default to mdb so the PR could be used to run the CI - Note: should revert that change before the final merge )