-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fundraising strategy document #868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @choldgraf!
Hmm. The deployment preview is red and failing. |
I think this is due to some scripts/notebooks being executed on build that require secrets, and by default secrets aren't available in PRs for security reasons. We should document this and/or provide a way to skip the parts of the build that require secrets in the PR context so we don't become nonchalant about dismissing failing builds and miss an actual failure. |
@sgibson91 I also created this reference guide for GH secrets https://team-compass.2i2c.org/reference/documentation/secrets/ |
I am biasing towards action and merging this in given that I presume @colliand has already cast eyes over it above 👀 |
@jnywong That's good, but I still think there needs to be a distinction between "This workflow failed because it couldn't access the secret" and "This workflow failed because the change actually broke something". Otherwise we stop trusting our tests, and if we don't trust tests then there's no point in having them. |
This converts our fundraising strategy document from Google Docs to the team compass so that it is more discoverable. I cleaned up some of the language and tried to add extra information, and added a little diagram as well.
I also copied over the language that @colliand used in https://github.com/2i2c-org/meta/issues/1189 since that felt like a good and already-formed bit of information to use.
Complementary post: