Merge pull request #21 from yuvipanda/fix-setup

Make sure `pip install` builds js assets

setup.py

@@ -8,35 +8,48 @@
 from subprocess import check_call
 
 from setuptools import setup
+from setuptools.command.build_py import build_py
 from setuptools.command.sdist import sdist
 
 HERE = os.path.dirname(__file__)
 
 
-class WebPackedSDist(sdist):
+def webpacked_command(command):
     """
-    Run npm webpack to generate appropriate output files before sdist.
-
-    This generates all the js & css we need, and that is included via an
-    entry in MANIFEST.in
+    Return a command that inherits from command, but adds webpack JS building
     """
 
-    description = "build frontend files with webpack"
-
-    def run(self):
+    class WebPackedCommand(command):
         """
-        Call npm install & npm run webpack before packaging
+        Run npm webpack to generate appropriate output files before given command.
+
+        This generates all the js & css we need, and that is included via an
+        entry in MANIFEST.in
         """
-        check_call(
-            ["npm", "install", "--progress=false", "--unsafe-perm"],
-            cwd=HERE,
-        )
 
-        check_call(["npm", "run", "webpack"], cwd=HERE)
+        description = "build frontend files with webpack"
+
+        def run(self):
+            """
+            Call npm install & npm run webpack before packaging
+            """
+            check_call(
+                ["npm", "install", "--progress=false", "--unsafe-perm"],
+                cwd=HERE,
+            )
+
+            check_call(["npm", "run", "webpack"], cwd=HERE)
+
+            return super().run()
 
-        return super().run()
+    return WebPackedCommand
 
 
 setup(
-    cmdclass={"sdist": WebPackedSDist},
+    cmdclass={
+        # Handles making sdists and wheels
+        "sdist": webpacked_command(sdist),
+        # Handles `pip install` directly
+        "build_py": webpacked_command(build_py),
+    },
 )