Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render url with .md to correct link #246

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

cmd-ntrf
Copy link
Contributor

@cmd-ntrf cmd-ntrf commented May 24, 2024

Links referring to other 2i2c blog posts are currently returning a 404 because they are improperly rendered.

Example of two links in Improvements to our team's planning and delivery

<a href="../../2023/organizational-report/index.md">our 2023 report of organizational strengths and weaknesses</a>
<a href="../../2023/organizational-report/index.md">released a report describing our organizational strengths and weaknesses</a>

I am not a Hugo expert, so I had to Google a solution, which I have included in this PR.

Also note that the GitHub link checker workflow appears to miss these broken links. I have yet found why as lychee was acting weirdly on my laptop.

@choldgraf
Copy link
Member

This is super cool, thanks for taking a look at it. First off, I've just merged a PR to fix these links here:

For future-proofing this, I think this PR could be very helpful, but it'll need an iteration because it currently breaks our external links :-)

I suggest that if you think you can resolve that issue with less than 30 minutes of thinking, let's go for it! But if it'll be too complex because writing Hugo is very confusing, we don't have to worry about it (one day I wanna switch these blog docs to MyST :-) )

@cmd-ntrf
Copy link
Contributor Author

Took me less time to fix this PR than the time to read that excellent blog post, so net positive.

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, this is really helpful! I added a quick TYVM to the code :-D

@choldgraf choldgraf merged commit af2e18f into 2i2c-org:main May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants