Skip to content

Commit

Permalink
height and width are not the same on different screens (facebook#2533)
Browse files Browse the repository at this point in the history
* height and width are not the same on different screens

height and width render significantly differently on different screens, and that's to be expected.

* Rephrased to clarify physical dimensions

* port change to the base docs

* remove blank line

Co-authored-by: Bartosz Kaszubowski <[email protected]>
  • Loading branch information
jimothyhalpert7 and Simek authored Mar 10, 2021
1 parent da50665 commit 0b67fbd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/height-and-width.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const FixedDimensionsBasics = () => {
export default FixedDimensionsBasics;
```

Setting dimensions this way is common for components that should always render at exactly the same size, regardless of screen dimensions.
Setting dimensions this way is common for components whose size should always be fixed to a number of points and not calculated based on screen size. Note, that there is no universal mapping from points to physical units of measurement. This means that a component with fixed dimensions might not have the same physical size, across different devices and screen sizes. However, this difference is unnoticable for most use cases.

## Flex Dimensions

Expand Down
2 changes: 1 addition & 1 deletion website/versioned_docs/version-0.63/height-and-width.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const FixedDimensionsBasics = () => {
export default FixedDimensionsBasics;
```

Setting dimensions this way is common for components that should always render at exactly the same size, regardless of screen dimensions.
Setting dimensions this way is common for components whose size should always be fixed to a number of points and not calculated based on screen size. Note, that there is no universal mapping from points to physical units of measurement. This means that a component with fixed dimensions might not have the same physical size, across different devices and screen sizes. However, this difference is unnoticable for most use cases.

## Flex Dimensions

Expand Down

0 comments on commit 0b67fbd

Please sign in to comment.