Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRP solver & task-manager #595

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

VRP solver & task-manager #595

wants to merge 1 commit into from

Conversation

i-bogomazov
Copy link
Contributor

Pull Request description

Changelog

  • new services added: VRP solver and VRP task manager

Issues

  • n/a

Breaking changes

  • n/a

internal documentation for VRP/TSP available:
https://confluence.2gis.ru/pages/viewpage.action?pageId=389323516

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@i-bogomazov i-bogomazov requested review from a team as code owners January 30, 2025 08:09
Comment on lines +96 to +104
# @section Kubernetes [Ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/) settings

# @param ingress.enabled If Ingress is enabled for the service.
# @param ingress.hosts[0].host Hostname for the Ingress service.

ingress:
enabled: false
hosts:
- host: vrp-solver.host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# @section Kubernetes [Ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/) settings
# @param ingress.enabled If Ingress is enabled for the service.
# @param ingress.hosts[0].host Hostname for the Ingress service.
ingress:
enabled: false
hosts:
- host: vrp-solver.host
# @section Kubernetes [Ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/) settings
# @param ingress.className Name of the Ingress controller class
# @param ingress.enabled If Ingress is enabled for the service
# @param ingress.hosts[0].host Hostname for the Ingress service
# @param ingress.hosts[0].paths[0].path Path of the host for the Ingress service
# @param ingress.hosts[0].paths[0].pathType Type of the path for the Ingress service
# @param ingress.tls TLS configuration
ingress:
className: nginx
enabled: false
hosts:
- host: navi-vrp-solver.example.com
paths:
- path: /
pathType: Prefix
tls: []
# - hosts:
# - navi-vrp-solver.example.com
# secretName: secret.tls

# @param image.pullPolicy Pull Policy

image:
repository: 2gis-on-premise/vrp-solver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repository: 2gis-on-premise/vrp-solver
repository: 2gis-on-premise/navi-vrp-solver

# @param image.pullPolicy Pull Policy

image:
repository: 2gis-on-premise/vrp-task-manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repository: 2gis-on-premise/vrp-task-manager
repository: 2gis-on-premise/navi-vrp-task-manager

Comment on lines +94 to +102
# @section Kubernetes [Ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/) settings

# @param ingress.enabled If Ingress is enabled for the service.
# @param ingress.hosts[0].host Hostname for the Ingress service.

ingress:
enabled: false
hosts:
- host: vrp-task-manager.host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# @section Kubernetes [Ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/) settings
# @param ingress.enabled If Ingress is enabled for the service.
# @param ingress.hosts[0].host Hostname for the Ingress service.
ingress:
enabled: false
hosts:
- host: vrp-task-manager.host
# @section Kubernetes [Ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/) settings
# @param ingress.className Name of the Ingress controller class
# @param ingress.enabled If Ingress is enabled for the service
# @param ingress.hosts[0].host Hostname for the Ingress service
# @param ingress.hosts[0].paths[0].path Path of the host for the Ingress service
# @param ingress.hosts[0].paths[0].pathType Type of the path for the Ingress service
# @param ingress.tls TLS configuration
ingress:
className: nginx
enabled: false
hosts:
- host: navi-vrp-task-manager.example.com
paths:
- path: /
pathType: Prefix
tls: []
# - hosts:
# - navi-vrp-task-manager.example.com
# secretName: secret.tls

Comment on lines +293 to +294
name: dm
user: dbuser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: dm
user: dbuser
name: ''
user: ''

@dbelyaev-nsk
Copy link
Contributor

задача на проверку https://jira.2gis.ru/browse/ONPREM-1465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants